MongoDB Bucket Storage Module #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rework-teardown # Conflicts: # packages/service-core/src/routes/endpoints/admin.ts
…e-zero-lsn-from-storage
…storage Removed Postgres ZeroLSN from BucketStorage
…rework-teardown # Conflicts: # packages/service-core/src/routes/endpoints/checkpointing.ts
# Conflicts: # modules/module-postgres/src/module/PostgresModule.ts # packages/service-core/src/api/diagnostics.ts # packages/service-core/src/replication/AbstractReplicationJob.ts # packages/service-core/src/replication/ReplicationModule.ts # packages/service-core/src/routes/endpoints/admin.ts # packages/service-core/src/routes/endpoints/sync-rules.ts # packages/service-core/src/system/ServiceContext.ts # packages/service-core/test/src/sync.test.ts # packages/types/src/config/PowerSyncConfig.ts
Implement powersync instance teardown functionality
…ture # Conflicts: # packages/service-core/src/routes/endpoints/socket-route.ts # pnpm-lock.yaml
rkistner
reviewed
Dec 30, 2024
rkistner
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Overall the structure here looks good to me.
One thing I'm wondering about in regards to the module structure - would it perhaps work better to create separate modules for replication vs storage?
One specific place this has an effect is with tests: Currently we have for example the mysql module with a devDependency on the mongodb module, so that the mongodb storage can be used with mysql tests. But we probably want to test all combinations of postgres/mongodb/mysql replication with mongodb/postgres storage. The dependency structure between the modules may start getting weird if we implement that.
rkistner
reviewed
Jan 7, 2025
rkistner
approved these changes
Jan 7, 2025
This was referenced Jan 8, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This moves the Mongo DB
BucketStorageimplementation out of the@powersync/service-corepackage to a new MongoDB Storage module.This PR also aims to move all MongoDB specific functionality to the MongoDB module. This includes:
Shared unit tests for the
BucketStorageFactoryare exported from the new@powersync/service-core-testspackage. These tests are used for testing the MongoDB and Postgres bucket storage factories.